chore(testing): use random seed instead of hardcoding #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
Rexicon226/random-seed
branch
from
c189c0a to
677c7ca
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
dnut
requested changes
Oct 6, 2025
There was a problem hiding this comment.
Overall I like this change. I commented on some stylistic preferences but I'm not asking you to change those things. My requested changes are:
- remove the TODO
- either remove
// sig fmt: offand// sig fmt: onor consolidate it back to one line - restore the
.or find another solution for the problem it was supposed to solve
dnut
previously approved these changes
Oct 7, 2025
yewman
previously approved these changes
Oct 21, 2025
Rexicon226
force-pushed
the
Rexicon226/random-seed
branch
from
5e86bbb to
d4350cd
Compare
Rexicon226
force-pushed
the
Rexicon226/random-seed
branch
from
0a71dd5 to
f222f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's preferred to use the random seed provided by the stdlib (which changes every run, but is deterministic, and can be passed into the test runner again to reproduce identical results), instead of just hardcoding a single number. This ensures the unit doesn't have some hidden dependence on the seed of the prng used.
Had to fix a couple cases just like this, where we would hardcode expected results which depend on the seed to the prng. The change makes it clearer what inputs are used to get said output.
Almost the entire diff is just that, maybe a few little fixes in random places.